On Wed, Jan 23, 2013 at 10:03:47AM +0100, Hans Verkuil wrote: ... > Right. And in my view there should be no default timestamp. Drivers should > always select MONOTONIC or COPY, and never UNKNOWN. The vb2 code should > check for that and issue a WARN_ON if no proper timestamp type was provided. > > v4l2-compliance already checks for that as well. I agree with that. Speaking of non-vb2 drivers --- I guess there's no reason for a driver not to use vb2 these days. There are actually already multple reasons to use it instead. So, vb2 drivers should choose the timestamps, and non-vb2 drivers... well, we shouldn't have more, but in case we do, they _must_ set the timestamp type, as there's no "default" since the relevant IOCTLs are handled by the driver itself rather than the V4L2 framework. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
