Hi Hans, Thanks for the comments! On Tue, Jan 22, 2013 at 08:03:01PM +0100, Hans Verkuil wrote: > On Tue January 22 2013 17:27:56 Sakari Ailus wrote: > > Use the same handlers where the structs are the same. Implement a new > > handler for link enumeration since struct media_links_enum is different on > > 32-bit and 64-bit systems. > > I think I would prefer to have the compat handling split off into a > seperate source. I know it is just a small amount of code at the moment, > but that's the way it is done as well for the V4L2 ioctls and I rather > like that approach. > > What do others think about that? I pondered the possibility but thought that as it's not much code so it'd be fine in the same file. I agree that hiding the compat code out of sight in V4L2 works really well --- it's mostly uninteresting and only needs to be touched when the API changes. But there's also much, much more code and handling to do in V4L2. I doubt the MC will ever be nearly as large unless the functionality and the problem area of the API changes significantly. I have nothing against putting this into a separate file, though. :-) -- Cheers, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
