RE: [PATCH 1/1] [media] s5p-mfc: Use WARN_ON(condition) directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, 

Thanks for the patch.

Best wishes,
-- 
Kamil Debski
Linux Platform Group
Samsung Poland R&D Center


> -----Original Message-----
> From: Sachin Kamat [mailto:sachin.kamat@xxxxxxxxxx]
> Sent: Tuesday, January 22, 2013 6:00 AM
> To: linux-media@xxxxxxxxxxxxxxx
> Cc: k.debski@xxxxxxxxxxx; s.nawrocki@xxxxxxxxxxx;
> sachin.kamat@xxxxxxxxxx; patches@xxxxxxxxxx
> Subject: [PATCH 1/1] [media] s5p-mfc: Use WARN_ON(condition) directly
> 
> Use WARN_ON(condition) directly instead of wrapping around an if
> condition.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>

Acked-by: Kamil Debski <k.debski@xxxxxxxxxxx>

> ---
>  drivers/media/platform/s5p-mfc/s5p_mfc.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> index b1d7f9a..37a17b8 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> @@ -596,8 +596,7 @@ static void s5p_mfc_handle_stream_complete(struct
> s5p_mfc_ctx *ctx,
> 
>  	clear_work_bit(ctx);
> 
> -	if (test_and_clear_bit(0, &dev->hw_lock) == 0)
> -		WARN_ON(1);
> +	WARN_ON(test_and_clear_bit(0, &dev->hw_lock) == 0);
> 
>  	s5p_mfc_clock_off();
>  	wake_up(&ctx->queue);
> --
> 1.7.4.1


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux