On 01/21/2013 10:18 AM, Ondrej Zary wrote:
On Monday 21 January 2013, Antti Palosaari wrote:
On 01/20/2013 11:22 PM, Ondrej Zary wrote:
Allow disabling I2C gate handling by external configuration.
This is required by cards that have all devices on a single I2C bus,
like AverMedia A706.
My personal opinion is that I2C gate control should be disabled setting
callback to NULL (same for the other unwanted callbacks too). There is
checks for callback existence in DVB-core, it does not call callback if
it is NULL.
This is TDA8290 internal I2C gate which is used by tda8290 internally and also
by tda827x or tda18271.
That sounds like there is some logical problems in the driver then, not
split correctly?
What I think, scenario is tda8290 is analog decoder, tda18271 is silicon
tuner, which is connected (usually) to the tda8290 I2C bus. tda18271
calls tda8290 I2C-gate control when needed. Analog or digital demod
should not call its own I2C gate directly - and if it was done in some
weird reason then it should call own callback conditionally, checking
whether or not it is NULL.
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
