Hi Sylwester,
On 16 January 2013 15:43, Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> wrote:
> Hi Sachin,
>
> I have just one small comment...
>
> On 01/07/2013 07:44 AM, Sachin Kamat wrote:
>> +static void *g2d_get_drv_data(struct platform_device *pdev)
>> +{
>> + struct g2d_variant *driver_data = NULL;
>> +
>> + driver_data = (struct g2d_variant *)
>> + platform_get_device_id(pdev)->driver_data;
>> +
>> + return driver_data;
>> +}
>
> How about adding this to g2d.h as:
>
> static inline struct g2d_variant *g2d_get_drv_data(struct platform_device *pdev)
> {
> return (struct g2d_variant *)platform_get_device_id(pdev)->driver_data;
> }
>
> ?
OK. I will move it to g2d.h and resend the patch.
>
> Otherwise the patch looks OK to me.
>
> --
>
> Thanks,
> Sylwester
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
