As it has been decided that i2-kbd-i2c isn't the way to go for i2c IR RC devices, remove the dependency on this module from the em28xx driver. We already use our own key polling functions with ir-kbd-i2c and the polling infrastructure is already on board, too (currently used for internal devices only). To avoid the risk of breaking things, just use the same key reporting mechanism as ir-i2c-kbd. The last two patches are optional, as they reduce the code size by ~20 lines at the cost of a minor performance drawback. Tested with device "Terratec Cinergy 200 USB" Patches 1+2: preparation Patch 3: actual dependency removal Patches 4+5: clean-up, comment/coding style fixes Patches 6+7: code size optimizations (optional) Frank Schäfer (7): em28xx-input: remove dead code line from em28xx_get_key_em_haup() em28xx: remove i2cdprintk() messages em28xx: get rid of the dependency on module ir-kbd-i2c em28xx: remove unused parameter ir_raw from i2c RC key polling functions em28xx: fix a comment and a small coding style issue em28xx: i2c RC devices: minor code size and memory usage optimization em28xx: input: use common work_struct callback function for IR RC key polling drivers/media/usb/em28xx/em28xx-input.c | 230 ++++++++++++++++--------------- drivers/media/usb/em28xx/em28xx.h | 3 - 2 Dateien geändert, 116 Zeilen hinzugefügt(+), 117 Zeilen entfernt(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html