Hans/Devin,
Em Fri, 4 Jan 2013 15:59:40 -0500
Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx> escreveu:
> TRY_FMT should not return an error if a pixelformat is unsupported. Instead just
> pick a common pixelformat.
>
> Also the bytesperline calculation was incorrect: it used the old width instead of
> the provided with, and it miscalculated the bytesperline value for the depth == 12
> case.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> Signed-off-by: Devin Heitmueller <dheitmueller@xxxxxxxxxxxxxx>
> ---
> drivers/media/usb/em28xx/em28xx-video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c
> index a91a248..7c09b55 100644
> --- a/drivers/media/usb/em28xx/em28xx-video.c
> +++ b/drivers/media/usb/em28xx/em28xx-video.c
> @@ -821,7 +821,7 @@ static int vidioc_try_fmt_vid_cap(struct file *file, void *priv,
> if (!fmt) {
> em28xx_videodbg("Fourcc format (%08x) invalid.\n",
> f->fmt.pix.pixelformat);
> - return -EINVAL;
> + fmt = format_by_fourcc(V4L2_PIX_FMT_YUYV);
This change has the potential of causing userspace regressions, so,
for now, I won't apply such change.
We need to discuss it better, before risk breaking things, and likely fix
applications first.
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
