Hi Guennadi, Thanks for the review. On Wednesday 02 January 2013 21:49:53 Guennadi Liakhovetski wrote: > On Wed, 2 Jan 2013, Laurent Pinchart wrote: > > Enable the regulators when powering the sensor up, and disable them when > > powering it down. > > > > The regulators are mandatory. Boards that don't allow controlling the > > sensor power lines must provide dummy regulators. > > I have been told several times, that (production) systems shouldn't use > dummy regulators, they can only be used during development until proper > regulators are implemented. Not that this should affect your patch, just > maybe we should avoid wording like "must provide dummy regulators" in > commit descriptions:-) Dummy was indeed a bad choice of word, I meant fixed voltage regulators. I'll fix the commit message. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html