Hi Fabio, On 2 January 2013 13:25, Fabio Estevam <festevam@xxxxxxxxx> wrote: > Hi Javier, > > On Wed, Jan 2, 2013 at 10:18 AM, javier Martin > <javier.martin@xxxxxxxxxxxxxxxxx> wrote: > >> That's great. Did you need to change anything in the mx2 camera driver >> for mx25 to work? Have you already submitted the patches? > > I only touched board file code: > http://www.spinics.net/lists/arm-kernel/msg210216.html > > ,and have only verified that camera probe worked on mx25pdk. Sorry Fabio but IMHO that's not enough. The probe() callback may work properly but it doesn't mean that buffer and HW handling for i.MX25 are functional. The condition to keep i.MX25 support in this file was that you were going to fix it but instead you have just added board support for a broken driver. I'd like to hear Guennadi's view on the matter but I think we've given plenty of time for this. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
