2012/12/28 Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>:
> Select is evil as it has issues with dependencies. Better to convert
> it to use depends on.
>
> That fixes a breakage with out-of-tree compilation of the media
> tree.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> ---
> drivers/media/platform/blackfin/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/blackfin/Kconfig b/drivers/media/platform/blackfin/Kconfig
> index 519990e..cc23997 100644
> --- a/drivers/media/platform/blackfin/Kconfig
> +++ b/drivers/media/platform/blackfin/Kconfig
> @@ -2,7 +2,6 @@ config VIDEO_BLACKFIN_CAPTURE
> tristate "Blackfin Video Capture Driver"
> depends on VIDEO_V4L2 && BLACKFIN && I2C
> select VIDEOBUF2_DMA_CONTIG
> - select VIDEO_BLACKFIN_PPI
> help
> V4L2 bridge driver for Blackfin video capture device.
> Choose PPI or EPPI as its interface.
> @@ -12,3 +11,5 @@ config VIDEO_BLACKFIN_CAPTURE
>
> config VIDEO_BLACKFIN_PPI
> tristate
> + depends on VIDEO_BLACKFIN_CAPTURE
> + default VIDEO_BLACKFIN_CAPTURE
> --
There are other drivers select this module.
config VIDEO_BLACKFIN_DISPLAY
tristate "Blackfin Video Display Driver"
depends on VIDEO_V4L2 && BLACKFIN && I2C
select VIDEOBUF2_DMA_CONTIG
select VIDEO_BLACKFIN_PPI
So should I move all other drivers to the depend on list?
Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
