Hi Hans, Sakari,
A quick question follows inline.
[snip]
> > diff --git a/drivers/media/v4l2-core/videobuf2-core.c
> > b/drivers/media/v4l2-core/videobuf2-core.c
> > index 432df11..19a5866 100644
> > --- a/drivers/media/v4l2-core/videobuf2-core.c
> > +++ b/drivers/media/v4l2-core/videobuf2-core.c
> > @@ -40,9 +40,10 @@ module_param(debug, int, 0644);
> > #define call_qop(q, op, args...) \
> > (((q)->ops->op) ? ((q)->ops->op(args)) : 0)
> >
> > -#define V4L2_BUFFER_STATE_FLAGS (V4L2_BUF_FLAG_MAPPED |
> V4L2_BUF_FLAG_QUEUED | \
> > +#define V4L2_BUFFER_MASK_FLAGS (V4L2_BUF_FLAG_MAPPED |
> V4L2_BUF_FLAG_QUEUED | \
> > V4L2_BUF_FLAG_DONE | V4L2_BUF_FLAG_ERROR |
\
> > - V4L2_BUF_FLAG_PREPARED)
> > + V4L2_BUF_FLAG_PREPARED | \
> > + V4L2_BUF_FLAG_TIMESTAMP_MASK)
> >
> > /**
> > * __vb2_buf_mem_alloc() - allocate video memory for the given
> buffer
> > @@ -367,7 +368,8 @@ static void __fill_v4l2_buffer(struct vb2_buffer
> *vb, struct v4l2_buffer *b)
> > /*
> > * Clear any buffer state related flags.
> > */
> > - b->flags &= ~V4L2_BUFFER_STATE_FLAGS;
> > + b->flags &= ~V4L2_BUFFER_MASK_FLAGS;
> > + b->flags |= V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
As far as I know, after __fill_v4l2_buffer is run driver has no means
to change flags. Right?
So how should a driver, which is not using the MONOTONIC timestamps inform
the user space about it?
> >
> > switch (vb->state) {
> > case VB2_BUF_STATE_QUEUED:
> > @@ -863,7 +865,7 @@ static void __fill_vb2_buffer(struct vb2_buffer
> > *vb, const struct v4l2_buffer *b
> >
> > vb->v4l2_buf.field = b->field;
> > vb->v4l2_buf.timestamp = b->timestamp;
> > - vb->v4l2_buf.flags = b->flags & ~V4L2_BUFFER_STATE_FLAGS;
> > + vb->v4l2_buf.flags = b->flags & ~V4L2_BUFFER_MASK_FLAGS;
> > }
> >
> > /**
> >
>
> Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
Best wishes,
--
Kamil Debski
Linux Platform Group
Samsung Poland R&D Center
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
