On Wed, Nov 14, 2012 at 11:04:42AM -0200, Fabio Estevam wrote: > commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) changed the > location of iram.h, which causes the following build error when building the coda > driver: > > drivers/media/platform/coda.c:27:23: error: mach/iram.h: No such file or directory > drivers/media/platform/coda.c: In function 'coda_probe': > drivers/media/platform/coda.c:2000: error: implicit declaration of function 'iram_alloc' > drivers/media/platform/coda.c:2001: warning: assignment makes pointer from integer without a cast > drivers/media/platform/coda.c: In function 'coda_remove': > drivers/media/platform/coda.c:2024: error: implicit declaration of function 'iram_free > > Since the content of iram.h is not imx specific, move it to include/linux/iram.h > instead. Generally we need a fix for this, but: > diff --git a/arch/arm/mach-imx/iram.h b/include/linux/iram.h > similarity index 100% > rename from arch/arm/mach-imx/iram.h > rename to include/linux/iram.h We shouldn't introduce a file include/linux/iram.h which is purely i.MX specific. The name is far too generic. I would rather suggest include/linux/platform_data/imx-iram.h (Although it's not exactly platform_data, so I'm open for better suggestions). As a side note this i.MX specific iram stuff (hopefully) is obsolete after the next merge window as Philip already has patches for a generic iram allocator which didn't make it into this merge window. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
