On 12/15/2012 03:03 AM, Mauro Carvalho Chehab wrote:
Em Sat, 15 Dec 2012 02:56:25 +0200
Antti Palosaari <crope@xxxxxx> escreveu:
NACK. NEC variant selection logic is broken by design.
If you think so, then feel free to fix it without causing regressions to
the existing userspace.
While you don't do it, I don't see anything wrong on this patch, as it
will behave just like any other NEC decoder.
yes, so true as I mentioned end of the mail. But it is very high
probability there is some non/wrong working keys when 32bit NEC variant
remote is used with that implementation.
And what happened those patches David sends sometime ago. I remember
there was a patch for the af9015 which removes that kind of logic from
the driver. If not change NEC to 32bit at least heuristic could be moved
to single point - rc-core.
regards
Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
