On Fri, Dec 14, 2012 at 6:02 PM, Antti Palosaari <crope@xxxxxx> wrote: > That one is better solution... > > but it is clearly DRXD driver bug - it should offer working I2C gate control > after attach() :-( I looked quickly DRXD driver and there is clearly some > other places to enhance too. But I suspect there is no maintainer, nor > interest from anyone to start fix things properly, so only reasonable way is > to add that hack to get it working... > > Honestly, I hate this kind of hacks :/ That makes our live hard on long run. > It goes slowly more and more hard to make any core changes as regressions > will happen due to this kind of hacks. > > So send new patch which put demod chip sleeping after tuner attach. Or even > better, find out what is minimal set of commands needed do execute during > attach in order to offer working I2C gate (I suspect firmware load is > needed). Opening the gate at the end of the attach callback should be a trivial exercise. Should just be a call to drxd_config_i2c(fe, enable) at the end of drxd_attach(). Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
