Hi Cyril, On Wed, Dec 12, 2012 at 5:54 AM, Cyril Roelandt <tipecaml@xxxxxxxxx> wrote: > vb2_dma_contig_init_ctx() returns ERR_PTR and never returns NULL, so IS_ERR > should be used instead of a NULL check. > patch fixing this issue has been already posted with a better fix https://patchwork.kernel.org/patch/1830231/ Regards, --Prabhakar Lad > Signed-off-by: Cyril Roelandt <tipecaml@xxxxxxxxx> > --- > drivers/media/platform/davinci/vpbe_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/davinci/vpbe_display.c b/drivers/media/platform/davinci/vpbe_display.c > index 2bfde79..2db4eff 100644 > --- a/drivers/media/platform/davinci/vpbe_display.c > +++ b/drivers/media/platform/davinci/vpbe_display.c > @@ -1393,7 +1393,7 @@ static int vpbe_display_reqbufs(struct file *file, void *priv, > } > /* Initialize videobuf queue as per the buffer type */ > layer->alloc_ctx = vb2_dma_contig_init_ctx(vpbe_dev->pdev); > - if (!layer->alloc_ctx) { > + if (IS_ERR(layer->alloc_ctx)) { > v4l2_err(&vpbe_dev->v4l2_dev, "Failed to get the context\n"); > return -EINVAL; > } > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
