On Tue, Dec 4, 2012 at 11:07 AM, Michael Krufky <mkrufky@xxxxxxxxxxx> wrote: > This patch removes the dependendency of VIDEO_AU0828 on VIDEO_V4L2 by > creating a new Kconfig option, VIDEO_AU0828_V4L2, which enables analog > video capture support and depends on VIDEO_V4L2 itself. > > With VIDEO_AU0828_V4L2 disabled, the driver will only support digital > television and will not depend on the v4l2-core. With VIDEO_AU0828_V4L2 > enabled, the driver will be built with the analog v4l2 support included. Hi Mike, This is generally good stuff. A couple of thoughts. It seems that this driver effectively takes the approach which is the exact reverse of all the other hybrid drivers - it mandates DVB with V4L as optional, whereas most of the other drivers mandate V4L with DVB is optional. Now I recognize that in this case it was done because of some specific business need -- however I have to wonder if the moving around of all the code to no longer be "video" vs. "dvb" specific could be leveraged to allow users to select either condition - to select DVB, V4L, or both. This seems like the direction things are going in -- we've restructured the tree based on bus interface type (pci/usb/etc) rather than v4l versus dvb. This might be an opportunity to define the model for how other hybrid devices could also be refactored to not have V4L or DVB if not needed. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
