On Thu, 29 Nov 2012 10:25:19 +0100 Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi Jean-Francois, Antonio Ospite, > > Could it be that you're both right, and that the register > Jean-Francois suggest is used (0x13) and uses in his patch > is for enabling / disabling the light-freq filter, where > as the register which were used before this patch > (0x2a, 0x2b) are used to select the light frequency to > filter for? > I too thought about something along this line after looking in the "OV7670 Implementation Guide": there is a relationship between the banding filter and the maximum exposure, and the latter is somewhat related to dummy lines/pixels. So this would make sense. > That would explain everything the 2 50 / 60 hz testers are > seeing. This assumes that reg 0x13 has the filter always > enabled before the patch, and the code before the patch > simply changes the filter freq to such a value it > effectively disables the filter for 50 Hz. This also > assumes that the default values in 0x2a and 0x2b are > valid for 60hz, which explains why Jean Francois' patch > works for 60 Hz, so with all this combined we should > have all pieces of the puzzle ... > > Anyone wants to do a patch to prove I'm right (or wrong :) > ? I contacted Fabian Alexander Calderon off-list using the email address in the tested-by line in the patch sent by Jean-Francois, I am waiting for a reply from him. I can cook something which uses register 0x13 and still makes the filter apply on 50Hz, but I'll test for an actual test before submitting it. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
