Hi Guennadi, On Mon, 26 Nov 2012 16:20:14 +0100 (CET) Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote: ... > > --- a/drivers/media/platform/soc_camera/soc_camera.c > > +++ b/drivers/media/platform/soc_camera/soc_camera.c > > @@ -902,6 +902,8 @@ static int soc_camera_s_crop(struct file *file, void *fh, > > dev_dbg(icd->pdev, "S_CROP(%ux%u@%u:%u)\n", > > rect->width, rect->height, rect->left, rect->top); > > > > + current_crop.type = a->type; > > + > > /* If get_crop fails, we'll let host and / or client drivers decide */ > > ret = ici->ops->get_crop(icd, ¤t_crop); > > > > What do you think? > > Yes, this makes sense. Please, submit a patch. Done. > > > And the type field should be checked in .s_crop() anyway, I think. > > It is checked in soc_camera_s_crop() just a couple of lines above the > snippet above. Or what do you mean? Yes, you are right! Okay, then there is no need to check it again in the subdevice driver. Thanks, Anatolij -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
