Hello Guennadi, Please see my comments below. Regards, Libin >-----Original Message----- >From: Albert Wang >Sent: Wednesday, November 28, 2012 12:06 AM >To: Guennadi Liakhovetski >Cc: corbet@xxxxxxx; linux-media@xxxxxxxxxxxxxxx; Libin Yang >Subject: RE: [PATCH 12/15] [media] marvell-ccic: add soc_camera support in mmp driver > >Hi, Guennadi > > >>-----Original Message----- >>From: Guennadi Liakhovetski [mailto:g.liakhovetski@xxxxxx] >>Sent: Tuesday, 27 November, 2012 23:54 >>To: Albert Wang >>Cc: corbet@xxxxxxx; linux-media@xxxxxxxxxxxxxxx; Libin Yang >>Subject: Re: [PATCH 12/15] [media] marvell-ccic: add soc_camera support in mmp >>driver >> [snip] >>> >>> mcam = &cam->mcam; >>> + spin_lock_init(&mcam->dev_lock); >>> mcam->plat_power_up = mmpcam_power_up; >>> mcam->plat_power_down = mmpcam_power_down; >>> mcam->ctlr_reset = mcam_ctlr_reset; >>> mcam->calc_dphy = mmpcam_calc_dphy; >>> mcam->dev = &pdev->dev; >>> mcam->use_smbus = 0; >>> + mcam->card_name = pdata->name; >>> + mcam->mclk_min = pdata->mclk_min; >>> + mcam->mclk_src = pdata->mclk_src; >>> + mcam->mclk_div = pdata->mclk_div; >> >>Actually you don't really have to copy everything from platform data to your private >>driver object during probing. You can access your platform data also at run-time. So, >>maybe you can survive without adding these >>.mclk_* struct members? >> >Yes, make sense. :) [Libin] We add such members because we need use these variables in the file mcam-core-soc.c. In the mcam-core-soc.c, the pdata is invisible. I think we can split the probe function and copy them in the file mcam-core-soc.c as you suggested. [snip] >>> + int chip_id; >>> /* >>> * MIPI support >>> */ >>> -- >>> 1.7.9.5 >>> >> >>Thanks >>Guennadi >>--- >>Guennadi Liakhovetski, Ph.D. >>Freelance Open-Source Software Developer >>http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
