On Fri, 23 Nov 2012 19:12:32 +0100
Jean-Francois Moine <moinejf@xxxxxxx> wrote:
> On Fri, 23 Nov 2012 18:09:09 +0100
> Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote:
[...]
> > In the datasheet I have for ov772x, bit[6] of register 0x13 is described
> > as:
> >
> > Bit[6]: AEC - Step size limit
> > 0: Step size is limited to vertical blank
> > 1: Unlimited step size
>
> Right, but I don't use the bit 6, it is the bit 5:
>
Ouch, right! :)
> > > + sccb_reg_write(gspca_dev, 0x13, /* auto */
> > > + sccb_reg_read(gspca_dev, 0x13) | 0x20);
>
> which is described as:
>
> Bit[5]: Banding filter ON/OFF
>
> > And the patch makes Light Frequency _NOT_ work with the PS3 eye (based
> > on ov772x).
> >
> > What does the ov767x datasheet say?
>
> Quite the same thing:
>
> Bit[5]: Banding filter ON/OFF - In order to turn ON the banding
> filter, BD50ST (0x9D) or BD60ST (0x9E) must be set to a
> non-zero value.
> 0: OFF
> 1: ON
>
> (the registers 9d and 9e are non zero for the ov767x in ov534.c)
>
In the ov767x datasheet I also see that selecting _what_ filter to
apply is done in Bit[3] of register 0x3B, but I couldn't find such info
for ov772x. (FYI a datasheet for ov7740 can be found on the web with
some theory but resisters are not always the same as ov772x).
> > Maybe we should use the new values only when
> > sd->sensor == SENSOR_OV767x
> >
> > What sensor does Alexander's webcam use?
>
> He has exactly the same webcam as yours: 1415:2000 (ps eye) with
> sensor ov772x.
>
> > > Note: The light frequency filter is either off or automatic.
> > > The application will see either off or "50Hz" only.
> > >
> > > Tested-by: alexander calderon <fabianp902@xxxxxxxxx>
> > > Signed-off-by: Jean-François Moine <moinejf@xxxxxxx>
> > >
> > > --- a/drivers/media/usb/gspca/ov534.c
> > > +++ b/drivers/media/usb/gspca/ov534.c
> > > @@ -1038,13 +1038,12 @@
> > > {
> > > struct sd *sd = (struct sd *) gspca_dev;
> > >
> >
> > drivers/media/usb/gspca/ov534.c: In function ‘setlightfreq’:
> > drivers/media/usb/gspca/ov534.c:1039:13: warning: unused variable ‘sd’ [-Wunused-variable]
>
> Thanks.
>
> Well, here is one of the last message I received from Alexander (in
> fact, his first name is Fabian):
>
> > Thanks for all your help, it is very kind of you, I used the code below,the
> > 60 Hz filter appear to work even at 100fps, but when I used 125 fps it
> > didnt work :( , i guess it is something of detection speed. If you have any
> > other idea I'll be very thankful.
> >
> > Sincerely Fabian Calderon
>
So he is in a place where a 60Hz power source is used?.
> So, how may we advance?
For now I'd NAK the patch since it is a regression for users
with 50Hz power sources and it looks like it does not _always_ work for
60Hz either.
Should I remove it from patchwork as well?
As I have the webcam and can perform actual tests I'll coordinate with
Fabian to have more details about why light frequency filter is not
working for him with the current code, it works fine for me at 640x480,
even if I can see that its effect is weaker at 320x240.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
