On 11/23/2012 10:47 AM, Sachin Kamat wrote: >>> +err_clk_prepare: >>> gsc_clk_put(gsc); >> >> This call can be removed too. I would remove all labels and gotos in >> this function. Since there is only one clock, you need to only call >> clk_put when clk_prepare() fails, there is no need for gsc_clk_put(). > > I have removed gsc_clk_put() in the subsequent patch in this series. > I will probably incorporate your previous comment and remove the label > altogether (in patch 3) and send it again. OK, sounds good to me that way too. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html