On 2012-11-21 18:24, Steffen Trumtrar wrote: > On Wed, Nov 21, 2012 at 02:49:30PM +0200, Tomi Valkeinen wrote: >>> @@ -715,6 +717,11 @@ extern void fb_destroy_modedb(struct fb_videomode *modedb); >>> extern int fb_find_mode_cvt(struct fb_videomode *mode, int margins, int rb); >>> extern unsigned char *fb_ddc_read(struct i2c_adapter *adapter); >>> >>> +#if IS_ENABLED(CONFIG_OF_VIDEOMODE) >>> +extern int of_get_fb_videomode(const struct device_node *np, >>> + struct fb_videomode *fb, >>> + unsigned int index); >>> +#endif >>> #if IS_ENABLED(CONFIG_VIDEOMODE) >>> extern int fb_videomode_from_videomode(const struct videomode *vm, >>> struct fb_videomode *fbmode); >> >> Do you really need these #ifs in the header files? They do make it look >> a bit messy. If somebody uses the functions and CONFIG_VIDEOMODE is not >> enabled, he'll get a linker error anyway. >> > > Well, I don't remember at the moment who requested this, but it was not my > idea to put them there. So, this is a matter of style I guess. > But maybe I understood that wrong. Right, one reviewer says this way, and another says that way =). With the header files I've made I only use #ifs with #else, when I want to give a static inline empty/no-op implementation for the function in case the feature is not compiled into the kernel. As you said, matter of taste. Up to you. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
