Re: [PATCH] exynos-gsc: Add missing video device vfl_dir flag initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sylwester,

I applied this patch and tested exynos-gsc driver basic features on exynos5250.
It's working fine for me.

Thanks,
Shaik Ameer Basha

On Tue, Nov 20, 2012 at 1:36 AM, Sylwester Nawrocki
<sylvester.nawrocki@xxxxxxxxx> wrote:
> Hi Shaik,
>
> Could you let us know if the driver is working fine with this patch
> applied ? I have no exynos5 based board to test it. And this patch
> qualifies as an important fix that should be applied for v3.7, where
> the driver's first appeared.
>
> Thanks,
> Sylwester
>
>
> On 11/10/2012 11:57 PM, Sylwester Nawrocki wrote:
>>
>> vfl_dir should be set to VFL_DIR_M2M so valid ioctls for this
>> mem-to-mem device can be properly determined in the v4l2 core.
>>
>> Cc: Shaik Ameer Basha<shaik.ameer@xxxxxxxxxxx>
>> Signed-off-by: Sylwester Nawrocki<sylvester.nawrocki@xxxxxxxxx>
>> ---
>> I didn't run-time test this patch.
>>
>>   drivers/media/platform/exynos-gsc/gsc-m2m.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c
>> b/drivers/media/platform/exynos-gsc/gsc-m2m.c
>> index 3c7f005..88642a8 100644
>> --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c
>> +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c
>> @@ -732,6 +732,7 @@ int gsc_register_m2m_device(struct gsc_dev *gsc)
>>         gsc->vdev.ioctl_ops     =&gsc_m2m_ioctl_ops;
>>         gsc->vdev.release       = video_device_release_empty;
>>         gsc->vdev.lock          =&gsc->lock;
>>
>> +       gsc->vdev.vfl_dir       = VFL_DIR_M2M;
>>         snprintf(gsc->vdev.name, sizeof(gsc->vdev.name), "%s.%d:m2m",
>>                                         GSC_MODULE_NAME, gsc->id);
>>
>> --
>> 1.7.4.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux