Yes, there are differences, simply because algorithms which use these tables are different ;-). On 14/11/2012 10:36, Frédéric wrote: > Le mercredi 14 novembre 2012, Frédéric a écrit : > >> I had a look at your patches. I don't see the '.fw_version' param anymore >> in the 'ngene_info' structure... Is it normal? > > I also noticed some differences in the PLL presets: > > In your patch: > > .entries = { > { 305000000, 166667, 0xb4, 0x12 }, > { 405000000, 166667, 0xbc, 0x12 }, > { 445000000, 166667, 0xbc, 0x12 }, > { 465000000, 166667, 0xf4, 0x18 }, > { 735000000, 166667, 0xfc, 0x18 }, > { 835000000, 166667, 0xbc, 0x18 }, > { 999999999, 166667, 0xfc, 0x18 }, > }, > > In original patch: > > if (freq<177000000 || freq>858000000) > return -EINVAL; > else if (freq<305000000) { c1=0xb4; c2=0x12; } > else if (freq<405000000) { c1=0xbc; c2=0x12; } > else if (freq<445000000) { c1=0xf4; c2=0x12; } > else if (freq<465000000) { c1=0xfc; c2=0x12; } > else if (freq<735000000) { c1=0xbc; c2=0x18; } > else if (freq<835000000) { c1=0xf4; c2=0x18; } > else { c1=0xfc; c2=0x18; } > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html