Hi Tomasz,
On Thursday 08 November 2012 16:28:12 Tomasz Stanislawski wrote:
> Hi Laurent,
> The fix was partially applied in "[PATCHv10 03/26] v4l: vb2: add support for
> shared buffer (dma_buf)". The data_offset is set to 0 for DMABUF
> capture/output for single-planar API.
My bad, I had an old version of your patch set in my git tree. The other half
of the patch should still be applied, but it can go through Mauro's tree
without going through yours.
> We should define the meaning of data_offset in case of USERPTR and MMAP
> buffers. For output device it is pretty intuitive.
>
> For DMABUF capture devices data_offset maybe used to inform a driver to
> capture the image at some offset inside the DMABUF buffer.
That's indeed missing from the documentation.
> BTW. Should {} be added after "if (V4L2_TYPE_IS_OUTPUT(b->type))"
> to avoid 'interesting' behavior? :)
Oops :-) I'll fix that.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
