Re: [PATCH 57/68] [media] anysee: fix a warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/27/2012 11:41 PM, Mauro Carvalho Chehab wrote:
drivers/media/usb/dvb-usb-v2/anysee.c:1179:5: warning: 'tmp' may be used uninitialized in this function [-Wmaybe-uninitialized]

Cc: Antti Palosaari <crope@xxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
---
  drivers/media/usb/dvb-usb-v2/anysee.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/dvb-usb-v2/anysee.c b/drivers/media/usb/dvb-usb-v2/anysee.c
index e78ca8f..d05c5b5 100644
--- a/drivers/media/usb/dvb-usb-v2/anysee.c
+++ b/drivers/media/usb/dvb-usb-v2/anysee.c
@@ -1170,7 +1170,7 @@ static int anysee_ci_poll_slot_status(struct dvb_ca_en50221 *ci, int slot,
  	struct dvb_usb_device *d = ci->data;
  	struct anysee_state *state = d_to_priv(d);
  	int ret;
-	u8 tmp;
+	u8 tmp = 0;

  	ret = anysee_rd_reg_mask(d, REG_IOC, &tmp, 0x40);
  	if (ret)


That is another one I have looked multiple times - you are even asked to look once few months back. I don't see how it could take that branch. Maybe uninitialized_var() is a little bit cheaper?

Anyway, I am OK with that too.

regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux