On 10/29/2012 11:21 AM, Mauro Carvalho Chehab wrote: > Hans Verkuil yesterday's build still got two warnings at the > generic drivers: > http://hverkuil.home.xs4all.nl/logs/Sunday.log > > They didn't appear at i386 build probably because of some > optimization done there. > > Anyway, fixing them are trivial, so let's do it. > > After applying those patches, the only drivers left producing > warnings are the following platform drivers: > > drivers/media/platform/davinci/dm355_ccdc.c > drivers/media/platform/davinci/dm644x_ccdc.c > drivers/media/platform/davinci/vpbe_osd.c > drivers/media/platform/omap3isp/ispccdc.c > drivers/media/platform/omap3isp/isph3a_aewb.c > drivers/media/platform/omap3isp/isph3a_af.c > drivers/media/platform/omap3isp/isphist.c > drivers/media/platform/omap3isp/ispqueue.c > drivers/media/platform/omap3isp/ispvideo.c > drivers/media/platform/omap/omap_vout.c > drivers/media/platform/s5p-fimc/fimc-capture.c > drivers/media/platform/s5p-fimc/fimc-lite.c For these two files I've sent already a pull request [1], which includes a fixup patch s5p-fimc: Don't ignore return value of vb2_queue_init() BTW, shouldn't things like these be taken care when someone does a change at the core code ? I'm not having issues in this case at all, but if there is many people doing constantly changes at the core it might imply for driver authors/maintainers wasting much of their time for fixing issues resulting from constant changes at the base code. Thanks, Sylwester > drivers/media/platform/sh_vou.c > drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c > > Platform driver maintainers: please fix, as those warnings could be > hiding real bugs. Also, removing all warnings is interesting, > as they helps to detect when new possible bugs got introduced. > > I think Hans also use "make W=1" option when doing his tests. > > Mauro Carvalho Chehab (2): > [media] drxk_hard: fix the return code from an error handler > [media] xc4000: Fix a few warnings > > drivers/media/dvb-frontends/drxk_hard.c | 1 + > drivers/media/tuners/xc4000.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) [1] http://patchwork.linuxtv.org/patch/15195/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
