Re: [PATCH] Add chipid to fc2580.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Mon, 22 Oct 2012 10:17:26 +0200
Oliver Schinagl <oliver+list@xxxxxxxxxxx> escreveu:

> diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
> index aff39ae..102d942 100644
> I found a fellow Asus U3100+ user (mentioned him before with the 
> firmware issue) that even when using the latest firmware, still see's 
> 0xff as the chipID.

You missed to add a signed-off-by on your patch.

Maybe it would make sense, in this case, to print some warning message,
as this could be due to a bug either at the hardware or at some place 
at the driver, like the gpio config settings for this device.

Anyway, Antti, your call.

> 
> 
> --- a/drivers/media/tuners/fc2580.c
> +++ b/drivers/media/tuners/fc2580.c
> @@ -497,6 +497,7 @@ struct dvb_frontend *fc2580_attach(struct 
> dvb_frontend *fe,
>          switch (chip_id) {
>          case 0x56:
>          case 0x5a:
> +       case 0xff:
>                  break;
>          default:
>                  goto err;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux