On Thu, Oct 04, 2012 at 07:59:19PM +0200, Steffen Trumtrar wrote: [...] > diff --git a/include/linux/of_display_timings.h b/include/linux/of_display_timings.h > new file mode 100644 > index 0000000..1ad719e > --- /dev/null > +++ b/include/linux/of_display_timings.h > @@ -0,0 +1,85 @@ > +/* > + * Copyright 2012 Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx> > + * > + * description of display timings > + * > + * This file is released under the GPLv2 > + */ > + > +#ifndef __LINUX_OF_DISPLAY_TIMINGS_H > +#define __LINUX_OF_DISPLAY_TIMINGS_H This file needs to include linux/slab.h because it uses kfree() in the inline functions. Alternatively I think I'd rather see the inline functions moved out of the header, with the exception of the signal_timing_get_value() function perhaps. Moreover there should be a forward declaration of struct display_node to avoid the need to include linux/of.h. Thierry
Attachment:
pgpPcXhIqIeI7.pgp
Description: PGP signature
