Re: [PATCH 2/2] [media] winbond: remove space from driver name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 12, 2012 at 01:16:36AM +0200, David Härdeman wrote:
> On Fri, Sep 28, 2012 at 09:44:33AM +0100, Sean Young wrote:
> >[root@pequod ~]# udevadm test /sys/class/rc/rc0
> >-snip-
> >ACTION=add
> >DEVPATH=/devices/pnp0/00:04/rc/rc0
> >DRV_NAME=Winbond CIR
> >NAME=rc-rc6-mce
> >SUBSYSTEM=rc
> >UDEV_LOG=6
> >USEC_INITIALIZED=88135858
> >run: '/usr/bin/ir-keytable -a /etc/rc_maps.cfg -s rc0'
> >
> >Having a space makes it impossible to match in /etc/rc_maps.cfg.
> >
> >Signed-off-by: Sean Young <sean@xxxxxxxx>
> >---
> > drivers/media/rc/winbond-cir.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c
> >index 30ae1f2..7c9b5f3 100644
> >--- a/drivers/media/rc/winbond-cir.c
> >+++ b/drivers/media/rc/winbond-cir.c
> >@@ -184,7 +184,7 @@ enum wbcir_txstate {
> > };
> > 
> > /* Misc */
> >-#define WBCIR_NAME	"Winbond CIR"
> >+#define WBCIR_NAME	"winbond-cir"
> 
> I'm not opposed to the change per se, but WBCIR_NAME is used for
> input_name as well and a quick "lsinput" on my laptop shows that all
> evdev devices (18 in total) have properly capitalized names.

You're right, I had missed that. I'll post a patch to correct it.


Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux