Hi Florian, On Wednesday 10 October 2012 09:19:37 Florian Neuhaus wrote: > Laurent Pinchart wrote on 2012-10-08: > > > > The OMAP3 ISP resizer can't scale down 1944 pixels (the native sensor > > height) to exactly 480 pixels as that would exceed the resizer limits. > > You will thus have to crop the sensor image slightly. Cropping is > > supported by libomap3isp and by the snapshot application but not by the > > live application. Ideally the live application or the libomap3isp library > > should realize that the ISP limits are exceeded and configure cropping on > > the sensor accordingly. As an interim solution you could add manual crop > > support to the live application using the snapshot application crop > > support code as an example. > > I have seen, that the resizer "only" supports downscaling by 0.25, so with > all the cropping, 1944 lines will come down to 482 which is too big for my > framebuffer. If I apply some cropping in the omap3_isp_viewfinder_setup > function, the output will work as expected. Now I'm going to crop on the > sensor (or better on the first entity that supports cropping, as in your > code) if the ratio "sensor input -> viewfinder output" exceeds 0.25. Are > you interested in a patch for this? Sure. I wonder if it wouldn't make more sense to crop on the resizer though, what do you think ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
