On Tue, Oct 9, 2012 at 6:44 PM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: > Em Sun, 7 Oct 2012 09:19:51 -0400 > Michael Krufky <mkrufky@xxxxxxxxxxx> escreveu: > >> umm, again, i didn't actually ACK the patch, I verbally said "ok, i guess" >> >> You shouldn't forge someone's signature, Mauro. :-( > > First of all, acked-by is not a signature. Those tags (acked, reviewed, tested, > reported, etc) are pure indications of the status of the patch, e. g. > if someone looked into the issue. > > In this specific case, what you said, instead was, literally: "So, I retract my NACK." > > Well, you're the driver maintainer, so I expected your considerations. > > You firstly reviewed it and gave a NACK. Then, you reviewed it again > and reverted a NACK. The opposite of a NACK is an ACK. This is pure boolean. > > If you had, instead asked me for more time to review, I would have kept > it in hold. > > Now that it got merged, what we can do is to revert it, if you have good > reasons for that, or to keep it. > > Your call. I understand. Thanks for explaining it. We spoke about this today in IRC, also... I'll send another patch when I have some time to address the trivial remaining issues. There is nothing wrong (afaik) with merging this patch for now. Thanks again, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
