Hi Laurent, Thanks for the comments. On Tue, Oct 09, 2012 at 02:33:28AM +0200, Laurent Pinchart wrote: ... > > @@ -248,10 +203,56 @@ static int csiphy_config(struct isp_csiphy *phy, > > if (lanes->clk.pos == 0 || used_lanes & (1 << lanes->clk.pos)) > > return -EINVAL; > > > > - mutex_lock(&phy->mutex); > > - phy->dphy = *dphy; > > - phy->lanes = *lanes; > > - mutex_unlock(&phy->mutex); > > + csiphy_routing_cfg(phy, subdevs->interface, true, > > + subdevs->bus.ccp2.phy_layer); > > As the second argument is always true, it could make sense to remove it (or to > add another call to csiphy_routing_cfg with on set to false). That's a good point. In principle another call should be added for 3430 to turn the PHY off. That's not being done on the N900. I'll see where it could be added. Regards, -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
