Re: [PATCH RFC] em28xx: PCTV 520e switch tda18271 to tda18271c2dd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 1, 2012 at 9:58 PM, Devin Heitmueller
<dheitmueller@xxxxxxxxxxxxxx> wrote:
> On Mon, Oct 1, 2012 at 8:52 PM, Antti Palosaari <crope@xxxxxx> wrote:
>> New drxk firmware download does not work with tda18271. Actual
>> reason is more drxk driver than tda18271. Anyhow, tda18271c2dd
>> will work as it does not do as much I/O during attach than tda18271.
>>
>> Root of cause is tuner I/O during drx-k asynchronous firmware
>> download. request_firmware_nowait()... :-/
>
> This seems like it's just changing the timing of the initialization
> process, which isn't really any better than the "msleep(2000)".  It's
> just dumb luck that it happens to work on the developer's system.
>
> Don't get me wrong, I agree with Michael that this whole situation is
> ridiculous, but I don't see why swapping out the entire driver is a
> reasonable fix.

I just send out a patch entitled, "tda18271: prevent register access
during attach() if delay_cal is set"   Antti, could you set
tda18271_config.delay_cal = 1 with this patch applied and see if it
solves your problem?

Again, although this may solve the problem for this particular device,
the *real* problem is this asynchronous firmware download in the demod
driver.

Nonetheless, Antti has been asking for this feature, to not allow
register access during attach, I was against it and I have my reasons,
but I believe that this patch is a fair compromise.

After somebody can test it, I think we should merge this -- any comments?

http://patchwork.linuxtv.org/patch/14799/

Regards,

Mike Krufky
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux