On Fri, 28 Sep 2012 21:47:39 +0800 Albert Wang <twang13@xxxxxxxxxxx> wrote: > This patch adds support of 3 frame buffers in DMA-contiguous mode. > > In current DMA_CONTIG mode, only 2 frame buffers can be supported. > Actually, Marvell CCIC can support at most 3 frame buffers. > > Currently 2 frame buffers mode will be used by default. > To use 3 frame buffers mode, can do: > define MAX_FRAME_BUFS 3 > in mcam-core.h I have no problem with the concept. I honestly don't remember why I only used the two-buffer mode for dma-contig; perhaps it's because getting even two buffers can be a bit of a challenge on a lot of systems, maybe. The application really needs to be able to get at least four buffers for the three-buffer mode to be worthwhile (otherwise you're always in a situation where the driver owns less than three and has to juggle things). But we can certainly add it. I wish this were two patches, though: 1) Change lots of int variables to unsigned int (with reasoning as to why we want to do that). 2) Add three-buffer mode. The mode should be runtime-selectable, as it is with the vmalloc mode. Otherwise seems OK. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
