Re: [PATCH 1/4] [media] mmp: add register definition for marvell ccic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 28 Sep 2012, Albert Wang wrote:

> From: Libin Yang <lbyang@xxxxxxxxxxx>
> 
> This patch adds the definition of CCIC1/2 Clock Reset register address
> 
> Signed-off-by: Albert Wang <twang13@xxxxxxxxxxx>
> Signed-off-by: Libin Yang <lbyang@xxxxxxxxxxx>
> ---
>  arch/arm/mach-mmp/include/mach/regs-apmu.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-mmp/include/mach/regs-apmu.h b/arch/arm/mach-mmp/include/mach/regs-apmu.h
> index 7af8deb..f2cf231 100755
> --- a/arch/arm/mach-mmp/include/mach/regs-apmu.h
> +++ b/arch/arm/mach-mmp/include/mach/regs-apmu.h
> @@ -16,7 +16,8 @@
>  /* Clock Reset Control */
>  #define APMU_IRE	APMU_REG(0x048)
>  #define APMU_LCD	APMU_REG(0x04c)
> -#define APMU_CCIC	APMU_REG(0x050)
> +#define APMU_CCIC_RST	APMU_REG(0x050)
> +#define APMU_CCIC2_RST	APMU_REG(0x0f4)

Assuming APMU_CCIC hasn't been used until now, changing its name is ok, 
but I think, registers in this list are ordered by their addresses, so, 
your addition should go between

#define APMU_SDH3	APMU_REG(0x0ec)
#define APMU_ETH	APMU_REG(0x0fc)

Thanks
Guennadi

>  #define APMU_SDH0	APMU_REG(0x054)
>  #define APMU_SDH1	APMU_REG(0x058)
>  #define APMU_USB	APMU_REG(0x05c)
> -- 
> 1.7.0.4
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux