Hi,
On 09/28/2012 08:37 PM, Albert Wang wrote:
>>> + ret = v4l2_subdev_call(sd, core, g_chip_ident,&id);
>
>> Yuck. Don't abuse this. g_chip_ident is for debugging purposes only.
>
> Yes, can remove it.
>
>>> + if (ret< 0) {
>>> + cam_err(mcam, "%s %d\n", __func__, __LINE__);
>>> + return ret;
>>> + }
>>> +
>>> + strcpy(cap->card, mcam->card_name);
>>> + strncpy(cap->driver, (const char *)&(id.ident), 4);
>
>> No, the name of the driver is the name of this module: marvell_ccic.
>> It's *not* the name of the sensor driver.
>
> Yes, maybe you are right, we misunderstood this usage.
>
> But I'm confused with how can we put the sensor module name to upper level?
> I mean upper level user want to know which sensor module is connecting to the controller.
> Currently, our user get the sensor module name by call this ioctl VIDIOC_QUERYCAP.
>
> Anyway, maybe we need change the usage model.
Is there anything preventing you from using VIDIOC_ENUM_INPUT/VIDIOC_G_INPUT
ioctls for that ?
--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
