Hi Jonathan,
thank you for your time.
On 26 September 2012 18:40, Jonathan Corbet <corbet@xxxxxxx> wrote:
> This is going to have to be quick, sorry...
>
> On Wed, 26 Sep 2012 11:47:53 +0200
> Javier Martin <javier.martin@xxxxxxxxxxxxxxxxx> wrote:
>
>> +static struct ov7670_win_size ov7670_win_sizes[2][4] = {
>> + /* ov7670 */
>
> I must confess I don't like this; now we've got constants in an array that
> was automatically sized before and ov7670_win_sizes[info->model]
> everywhere. I'd suggest a separate array for each device and an
> ov7670_get_wsizes(model) function.
>
>> + /* CIF - WARNING: not tested for ov7675 */
>> + {
>
> ...and this is part of why I don't like it. My experience with this
> particular sensor says that, if it's not tested, it hasn't yet seen the
> magic-number tweaking required to actually make it work. Please don't
> claim to support formats that you don't know actually work, or I'll get
> stuck with the bug reports :)
Your concern makes a lot of sense. In fact, that was one of my doubts
whether to 'support' not tested formats or not.
Let me fix that in a new version.
--
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
