Hi Chris, On Wed, Sep 26, 2012 at 12:23 PM, Chris MacGregor <chris@xxxxxxxxxxxxx> wrote: > Hi All. > > > On 09/25/2012 11:44 PM, Prabhakar Lad wrote: >> >> Hi All, >> >> On Sun, Sep 23, 2012 at 4:56 PM, Prabhakar Lad >> <prabhakar.csengg@xxxxxxxxx> wrote: >>> >>> Hi All, >>> >>> The CCD/Sensors have the capability to adjust the R/ye, Gr/Cy, Gb/G, >>> B/Mg gain values. >>> Since these control can be re-usable I am planning to add the >>> following gain controls as part >>> of the framework: >>> >>> 1: V4L2_CID_GAIN_RED >>> 2: V4L2_CID_GAIN_GREEN_RED >>> 3: V4L2_CID_GAIN_GREEN_BLUE >>> 4: V4L2_CID_GAIN_BLUE >>> 5: V4L2_CID_GAIN_OFFSET >>> >>> I need your opinion's to get moving to add them. >>> >> I am listing out the gain controls which is the outcome of above >> discussion:- >> >> 1: V4L2_CID_GAIN_RED >> 2: V4L2_CID_GAIN_GREEN_RED >> 3: V4L2_CID_GAIN_GREEN_BLUE >> 4: V4L2_CID_GAIN_BLUE >> 5: V4L2_CID_GAIN_OFFSET >> 6: V4L2_CID_BLUE_OFFSET >> 7: V4L2_CID_RED_OFFSET >> 8: V4L2_CID_GREEN_OFFSET >> >> Please let me know for any addition/deletion. > > > I thought the consensus was that we would also need a V4L2_CID_GAIN_GREEN, > to handle devices for which there are not two separate greens. > Ok, I'll add it too. > Also, should there be a V4L2_CID_GREEN_RED_OFFSET and > V4L2_CID_GREEN_BLUE_OFFSET, for consistency and to handle hardware that has > such offsets? > +1 (But I would like opinions form others too for these control) > (Perhaps I missed an email in this thread, but I thought I caught them all.) > May be I missed out :( Thanks And Regards, --Prabhakar Lad >> Regards, >> --Prabhakar Lad > > > Cheers, > Chris MacGregor (the Seattle one) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html