Em Fri, 14 Sep 2012 13:15:36 +0200
Hans Verkuil <hans.verkuil@xxxxxxxxx> escreveu:
> Fixes a v4l2-compliance error: setting audmode to a value other than mono
> or stereo for a radio device should map to MODE_STEREO.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---
> drivers/media/v4l2-core/tuner-core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c
> index b5a819a..ea71371 100644
> --- a/drivers/media/v4l2-core/tuner-core.c
> +++ b/drivers/media/v4l2-core/tuner-core.c
> @@ -1235,8 +1235,11 @@ static int tuner_s_tuner(struct v4l2_subdev *sd, struct v4l2_tuner *vt)
> if (set_mode(t, vt->type))
> return 0;
>
> - if (t->mode == V4L2_TUNER_RADIO)
> + if (t->mode == V4L2_TUNER_RADIO) {
> t->audmode = vt->audmode;
> + if (t->audmode > V4L2_TUNER_MODE_STEREO)
> + t->audmode = V4L2_TUNER_MODE_STEREO;
NACK. It is not a core's task to fix driver's bugs. It would be ok to have here a
WARN_ON(), but, if a driver is reporting a wrong radio audmode, the fix should be
there at the drivers, and not here at the core.
> + }
> set_freq(t, 0);
>
> return 0;
--
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
