Re: [PATCH 2/4] pwc: Add return code check at vb2_queue_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thanks I've added this to my media tree and it will be included in
my next pull-req to Mauro.

Regards,

Hans


On 09/17/2012 03:47 PM, elezegarcia@xxxxxxxxx wrote:
From: Ezequiel Garcia <elezegarcia@xxxxxxxxx>

This function returns an integer and it's mandatory
to check the return code.

Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Ezequiel Garcia <elezegarcia@xxxxxxxxx>
---
  drivers/media/usb/pwc/pwc-if.c |    4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c
index 42e36ba..31d082e 100644
--- a/drivers/media/usb/pwc/pwc-if.c
+++ b/drivers/media/usb/pwc/pwc-if.c
@@ -1000,7 +1000,9 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
  	pdev->vb_queue.buf_struct_size = sizeof(struct pwc_frame_buf);
  	pdev->vb_queue.ops = &pwc_vb_queue_ops;
  	pdev->vb_queue.mem_ops = &vb2_vmalloc_memops;
-	vb2_queue_init(&pdev->vb_queue);
+	rc = vb2_queue_init(&pdev->vb_queue);
+	if (rc)
+		goto err_free_mem;

  	/* Init video_device structure */
  	memcpy(&pdev->vdev, &pwc_template, sizeof(pwc_template));

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux