Re: [PATCH 2/3] fc2580: silence uninitialized variable warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/24/2012 02:37 PM, Gianluca Gennari wrote:
fc2580.c: In function 'fc2580_set_params':
fc2580.c:118: warning: 'ret' may be used uninitialized in this function

Signed-off-by: Gianluca Gennari <gennarone@xxxxxxxxx>
---
  drivers/media/tuners/fc2580.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
index 036e94b..3ad68e9 100644
--- a/drivers/media/tuners/fc2580.c
+++ b/drivers/media/tuners/fc2580.c
@@ -115,7 +115,7 @@ static int fc2580_set_params(struct dvb_frontend *fe)
  {
  	struct fc2580_priv *priv = fe->tuner_priv;
  	struct dtv_frontend_properties *c = &fe->dtv_property_cache;
-	int ret, i;
+	int ret=0, i;

Nack. This is Codingstyle violation. See rules around line 206 from Documentation/CodingStyle

That replace warning with Codingstyle mistake. Change it to meet CodingStyle and resend.


  	unsigned int r_val, n_val, k_val, k_val_reg, f_ref;
  	u8 tmp_val, r18_val;
  	u64 f_vco;


Antti
--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux