Hello, On Monday, September 24, 2012 8:18 AM Sachin Kamat wrote: > v4l2_m2m_release() was placed after the return statement and outside > any of the goto labels and hence was not getting executed under the > error exit path. This patch moves it under the exit path label. > > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> Acked-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > --- > drivers/media/platform/mem2mem_testdev.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/platform/mem2mem_testdev.c > b/drivers/media/platform/mem2mem_testdev.c > index 771a84f..fc95559 100644 > --- a/drivers/media/platform/mem2mem_testdev.c > +++ b/drivers/media/platform/mem2mem_testdev.c > @@ -1067,8 +1067,8 @@ static int m2mtest_probe(struct platform_device *pdev) > > return 0; > > - v4l2_m2m_release(dev->m2m_dev); > err_m2m: > + v4l2_m2m_release(dev->m2m_dev); > video_unregister_device(dev->vfd); > rel_vdev: > video_device_release(vfd); > -- > 1.7.4.1 Best regards -- Marek Szyprowski Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html