Re: [PATCH 07/16] rtl2830: use .get_if_frequency()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/24/2012 02:17 AM, Mauro Carvalho Chehab wrote:
Em Thu, 13 Sep 2012 03:23:48 +0300
Antti Palosaari <crope@xxxxxx> escreveu:

Use .get_if_frequency() as all used tuner drivers
(mt2060/qt1010/mxl5005s) supports it.

Signed-off-by: Antti Palosaari <crope@xxxxxx>

@@ -240,26 +237,6 @@ static int rtl2830_init(struct dvb_frontend *fe)
  	if (ret)
  		goto err;

-	num = priv->cfg.if_dvbt % priv->cfg.xtal;
-	num *= 0x400000;
-	num = div_u64(num, priv->cfg.xtal);
-	num = -num;
-	if_ctl = num & 0x3fffff;
-	dev_dbg(&priv->i2c->dev, "%s: if_ctl=%08x\n", __func__, if_ctl);
-
-	ret = rtl2830_rd_reg_mask(priv, 0x119, &tmp, 0xc0); /* b[7:6] */
-	if (ret)
-		goto err;
-
-	buf[0] = tmp << 6;
-	buf[0] |= (if_ctl >> 16) & 0x3f;
-	buf[1] = (if_ctl >>  8) & 0xff;
-	buf[2] = (if_ctl >>  0) & 0xff;

Patch applied, but there was a context difference above:

  --- a/drivers/media/dvb-frontends/rtl2830.c
  +++ b/drivers/media/dvb-frontends/rtl2830.c
  @@ -182,9 +182,6 @@ static int rtl2830_init(struct dvb_frontend *fe)
@@ -28,7 +50,7 @@ index eca1d72..3954760 100644
  -		goto err;
  -
  -	buf[0] = tmp << 6;
--	buf[0] = (if_ctl >> 16) & 0x3f;
+-	buf[0] |= (if_ctl >> 16) & 0x3f;
  -	buf[1] = (if_ctl >>  8) & 0xff;
  -	buf[2] = (if_ctl >>  0) & 0xff;
  -

(that's the diff between the patch applied and your original one)

Because of that:

http://patchwork.linuxtv.org/patch/14066/

regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux