On Sun, Sep 23, 2012 at 7:39 PM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: > Laurent, > > Could you please review this patch? > > Peter, > > Please, always c/c the driver maintainer/author on patches you submit. > > You can check it with scripts/get_maintainer.pl. Sorry for that. I'll be more careful next time. Thanks! > > Regards, > Mauro > > -------- Mensagem original -------- > Assunto: [PATCH 5/5] drivers/media/platform/omap3isp/isp.c: fix error return code > Data: Tue, 4 Sep 2012 18:14:25 +0200 > De: Peter Senna Tschudin <peter.senna@xxxxxxxxx> > Para: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> > CC: kernel-janitors@xxxxxxxxxxxxxxx, Julia.Lawall@xxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx > > From: Peter Senna Tschudin <peter.senna@xxxxxxxxx> > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl> > > Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx> > > --- > drivers/media/platform/omap3isp/isp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index e0096e0..91fcaef 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2102,8 +2102,10 @@ static int __devinit isp_probe(struct platform_device *pdev) > if (ret < 0) > goto error; > > - if (__omap3isp_get(isp, false) == NULL) > + if (__omap3isp_get(isp, false) == NULL) { > + ret = -EBUSY; /* Not sure if EBUSY is best for here */ > goto error; > + } > > ret = isp_reset(isp); > if (ret < 0) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
