On Fri, 24 Aug 2012 16:32:57 +0200 (CEST) Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote: ... > > > But why do we have to write it here at all then? Autoexposure can be off > > > only if the user has set exposure manually, using V4L2_CID_EXPOSURE_AUTO. > > > In this case MT9V022_TOTAL_SHUTTER_WIDTH already contains the correct > > > value. Why do we have to set it again? Maybe just adding a comment, > > > explaining the above, would suffice? > > > > Actually we do not have to write it here, yes. Should I remove the shutter > > register setting here entirely? And add a comment explaining, why? > > Remove it from the "else" clause, yes, please. And a comment would be > good! Ok, I'll resubmit a reworked patch. Thanks, Anatolij -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
