RE: [PATCH] nommu: remap_pfn_range: fix addr parameter check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Scott Jiang [mailto:scott.jiang.linux@xxxxxxxxx]
> Sent: Friday, September 14, 2012 2:53 PM
> To: Andrew Morton
> Cc: Bob Liu; linux-mm@xxxxxxxxx; Bhupesh SHARMA;
> laurent.pinchart@xxxxxxxxxxxxxxxx; uclinux-dist-
> devel@xxxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx;
> dhowells@xxxxxxxxxx; geert@xxxxxxxxxxxxxx; gerg@xxxxxxxxxxx;
> stable@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; Hugh Dickins
> Subject: Re: [PATCH] nommu: remap_pfn_range: fix addr parameter check
> 
> > Yes, the MMU version of remap_pfn_range() does permit non-page-
> aligned
> > `addr' (at least, if the userspace maaping is a non-COW one).  But I
> > suspect that was an implementation accident - it is a nonsensical
> > thing to do, isn't it?  The MMU cannot map a bunch of kernel pages
> > onto a non-page-aligned userspace address.
> >
> > So I'm thinking that we should declare ((addr & ~PAGE_MASK) != 0) to
> > be a caller bug, and fix up this regrettably unidentified v4l driver?
> 
> I agree. This should be fixed in videobuf.
> 
> Hi sharma, what's your kernel version? It seems videobuf2 already fixed this
> bug in 3.5.

Hi Scott,

I was using 3.3 linux kernel. I will again check if videobuf2 in 3.5 has already fixed this issue.

Regards,
Bhupesh


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux