On Thu 13 September 2012 13:19:14 javier Martin wrote: > On 13 September 2012 13:00, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > On Thu 13 September 2012 12:47:53 javier Martin wrote: > >> >> 3.- Adjust vstart/vstop in order to remove an horizontal green line. > >> >> > >> >> Why? Currently, in the driver, for VGA, vstart = 10 and vstop = 490. > >> >> From our tests we found out that vstart = 14, vstop = 494 in order to > >> >> remove a disgusting horizontal green line in ov7675. > >> >> How? It seems these sensor aren't provided with a version register or > >> >> anything similar so I can't think of a clean solution for this yet. > >> >> Suggestions will be much appreciated. > >> > > >> > Using platform_data for this is what springs to mind. > >> > >> I had thought about it too but, there > > > > Unfinished sentence? > > > > Yes. Sorry :) > > I meant that I had thought about it too but there are one pair of > vstart,vstop values for each supported resolution: VGA, QVGA, CIF, > QCIF. > I could add 'vstart_vga', 'vstop_vga' as platform_data but in the > future someone could want to add the same values for the other ones > and I don't know if that would be acceptable. > > Another solution I just came up with would be adding a flag 'version' > where we could indicate if we are dealing with an ov7670 or an ov7675 > and change those 'vstart', 'vstop' values internally based on this. > This could be useful for some other issues in the future. You can actually add support for a ov7675 to the ov7670 driver itself by adding a ov7675 entry to the ov7670_id table. See for example the i2c/saa7127.c driver on how to do that. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
