Re: [PATCH v4 12/16] media: coda: add byte size slice limit control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Javier,

Am Dienstag, den 11.09.2012, 12:50 +0200 schrieb javier Martin:
> On 10 September 2012 17:29, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
> > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > ---
> >  drivers/media/platform/coda.c |   29 +++++++++++++++++++++++------
> >  1 file changed, 23 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
> > index 81e3401..863b96a 100644
> > --- a/drivers/media/platform/coda.c
> > +++ b/drivers/media/platform/coda.c
[...]
> > @@ -1346,10 +1361,12 @@ static int coda_ctrls_setup(struct coda_ctx *ctx)
> >                 V4L2_CID_MPEG_VIDEO_MPEG4_P_FRAME_QP, 1, 31, 1, 2);
> >         v4l2_ctrl_new_std_menu(&ctx->ctrls, &coda_ctrl_ops,
> >                 V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE,
> > -               V4L2_MPEG_VIDEO_MULTI_SICE_MODE_MAX_MB, 0,
> > -               V4L2_MPEG_VIDEO_MULTI_SICE_MODE_MAX_MB);
> > +               V4L2_MPEG_VIDEO_MULTI_SICE_MODE_MAX_BYTES, 0x7,
> > +               V4L2_MPEG_VIDEO_MULTI_SLICE_MODE_SINGLE);
> 
> The mask must be 0x0 instead of 0x7. Otherwise you are forbidding all
> the possible values for this ctrl and that won't work.

Thank you, will fix that.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux