On 08/30/2012 11:36 AM, Rémi Cardona wrote: > Since b9bf2eafaad9c1ef02fb3db38c74568be601a43a, the function > ds3000_firmware_ondemand() is called only once during init. This > locking scheme may have been useful when the firmware was loaded at > each tune. > > Furthermore, it looks like this 'lock' was put in to prevent concurrent > access (and not recursion as the comments suggest). However, this open- > coded mechanism is anything but race-free and should have used a proper > mutex. > > Signed-off-by: Rémi Cardona <remi.cardona@xxxxxxxxxxxx> > --- > drivers/media/dvb/frontends/ds3000.c | 9 --------- > 1 file changed, 9 deletions(-) Ping on that patch. Could anyone take a look at it? Many thanks, Rémi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html